Fix mouse wheel scroll-up not working #210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #210 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 391 391
=====================================
Hits 391 391
Continue to review full report at Codecov.
|
|
Thank you very much for you PR. I'll verify and test this in the next days. |
…ChromeVox. known bug: when selecting an option, ChromeVox says "listbox with zero items, X selected" which doesn't make sense, but have seen some markups where it works properly but couldn't figure out what makes it do that
|
The fix works for me. Thanks @pszoldan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix commit. Scrolling with the mouse wheel only works downwards, but not upwards in the open selectric panel. This is because the condition to prevent scrolling up when we're already at the top takes the position from the wrong element and it always thinks it's scrolled all the way up, preventing any further scroll upwards. This commit fixes it by taking the scroll position from the correct element, the parent.