Add test for a small newton raphson package #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smit-create
force-pushed
the
i-992-1
branch
2 times, most recently
from
b8001d1
to
124f014
Compare
certik
reviewed
Mar 23, 2023
integration_tests/nrp/nr.py
Outdated
| while abs(func(x, c)) > err and i < maxiter: | ||
| h = func(x, c) / func_prime(x, c) | ||
| x = x - h | ||
| i += 1 |
There was a problem hiding this comment.
Ah, some wierd issue. I have used a tab for indenting and locally looks fine.
There was a problem hiding this comment.
We should probably set some pre-commit hooks to autoformat the code when commiting. we can use python black as the formatter.
There was a problem hiding this comment.
We should use LPython as the formatter. :)
|
Beautiful, that's exactly what we need. Thanks! |
Smit-create
force-pushed
the
i-992-1
branch
2 times, most recently
from
ca43803
to
144347e
Compare
certik
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests only on an already-defined function. We will modify this test to accept callbacks once we complete working on #1608
Related to #992