Dict bool keys #1771
Dict bool keys #1771
Conversation
integration_tests/test_dict_bool.py
Outdated
There was a problem hiding this comment.
We are doing d[True] and d[False]. Let's also do something like,
d[i%2 == 0] += 1
And check the count of odd and even numbers for some range [0, n). To make sure things work correctly for runtime boolean keys.
There was a problem hiding this comment.
Looks like += isn't currently supported for dict yet. I have added this test with =.
There was a problem hiding this comment.
No worries.
Looks like
+=isn't currently supported fordictyet.
Let's support this in a separate PR, once you complete this and your other open PR.
There was a problem hiding this comment.
Did you generate these by hand?
There was a problem hiding this comment.
No, I added (and later removed) a test in ./tests/tests.toml with asr and asr_json options.
There was a problem hiding this comment.
Ah I see.Then you can remove these .stdout and .json files. Not needed any more.
I added (and later removed) a test in
./tests/tests.toml
Correct thing to do.
kabra1110
force-pushed
the
dict_bool
branch
2 times, most recently
from
1adf567
to
330efef
Compare
Work in progress. Towards #1710.