Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test based on basic_new_heap function #2190

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Added test based on basic_new_heap function #2190

merged 1 commit into from
Jul 20, 2023

Conversation

anutosh491
Copy link
Collaborator

No description provided.

@anutosh491
Copy link
Collaborator Author

TODO for subsequent PRs:

  • Add a line under print to also test using assert: assert basic_str(x) == "pi"
  • enable LLVM backend (we need to add llvm_sym into CMake and add this label)
  • add a test for basic_new_stack (this should be a new test file)

@anutosh491
Copy link
Collaborator Author

I've added the assert check in this pr itself as it was simple 1 line addition . I'll address the remaining TODO's through subsequent prs.

@anutosh491
Copy link
Collaborator Author

cc @certik All tests seems to pass . I think this could be merged .

certik
certik approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is good. Thanks!

@certik certik merged commit d559090 into lcompilers:main Jul 20, 2023
@anutosh491 anutosh491 deleted the GSoC_Pr_7 branch July 20, 2023 05:14
@anutosh491
Copy link
Collaborator Author

Thanks . I'll create the new pull requests now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
symbolic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anutosh491 @certik