Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Refactoring for the ASR Symbolic Pass #2320

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

anutosh491
Copy link
Collaborator

@anutosh491 anutosh491 commented Sep 11, 2023

There were some repetetions while declaring functions like basic_str (repeated 3 times), integer_set_si (repeated 2 times). After this PR, there are no duplications while declaring any function in the module scope and every function is only declared once.

Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is good, thanks!

@certik certik merged commit f16201f into lcompilers:main Sep 11, 2023
12 checks passed
@anutosh491 anutosh491 deleted the refactoring_symbolic_pass branch September 11, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants