fixes semantic error for int (Issue #1926) #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anutosh491
approved these changes
Feb 4, 2024
certik
reviewed
Feb 5, 2024
| @@ -876,7 +876,12 @@ class CommonVisitor : public AST::BaseVisitor<Struct> { | |||
| } | |||
|
|
|||
| if( !type && raise_error ) { | |||
| throw SemanticError("Unsupported type annotation: " + var_annotation, loc); | |||
| if (var_annotation == "int") { | |||
| throw SemanticError(var_annotation + " type is not supported yet. " , loc); | |||
There was a problem hiding this comment.
Add a hint: "hint: use i8, i16, i32 or i64 for now". Lookup other place in the code how to add a hint.
There was a problem hiding this comment.
Please review the changes I have made.
certik
reviewed
Feb 5, 2024
|
Resolved Issue #1926 by refining the semantic error message for 'int'. Changes: |
certik
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link: #1926
Changes:
Introduces a clear error message:
Context:
As discussed in this comment, this improvement enhances the usability of LPython.