Combine global_init and global_stmts functions into global_stmts
#2696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vipul-Cariappa
force-pushed
the
combine-init-and-stmts
branch
from
c5cda5a
to
ff9e6db
Compare
Comment on lines
4878
to
4885
| if (!global_init.empty()) { | ||
| for (auto t: global_init) { | ||
| if (t) { | ||
| items.push_back(al, t); | ||
| global_init.erase(t); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think this can be simplified to
Suggested change
| if (!global_init.empty()) { | |
| for (auto t: global_init) { | |
| if (t) { | |
| items.push_back(al, t); | |
| global_init.erase(t); | |
| } | |
| } | |
| } | |
| for (auto t: global_init) { | |
| if (t) { | |
| items.push_back(al, t); | |
| } | |
| } | |
| global_init.n = 0; |
|
Please add the test case in #2573 (comment) as integration test. Please ensure you add assert and print before the assert appropriately. |
|
Please mark this PR as "Ready for Review" when ready. |
integration_tests/CMakeLists.txt
Outdated
| @@ -508,6 +508,8 @@ RUN(NAME expr_02u LABELS cpython llvm llvm_jit c NOFAST) | |||
| RUN(NAME expr_03u LABELS cpython llvm llvm_jit c NOFAST) | |||
| RUN(NAME expr_04u LABELS cpython llvm llvm_jit c) | |||
|
|
|||
| RUN(NAME list_01 LABELS cpython llvm llvm_jit c) | |||
There was a problem hiding this comment.
It seems this test fails withc backend at the CI. So let's remove it.
Suggested change
| RUN(NAME list_01 LABELS cpython llvm llvm_jit c) | |
| RUN(NAME list_01 LABELS cpython llvm llvm_jit) |
Shaikh-Ubaid
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2573