-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed require statements #525
base: master
Are you sure you want to change the base?
Conversation
Thank you for your work. Please see my review. Before merging, can please you ensure that you tested every widget, layout and utility? Maybe you can help me with #527 as well. |
Thanks for the review. I reverted the change.
|
Unfortunately not, we need to call in each of them all possible functions/widgets with all possible arguments to see if anything breaks in a new commit.
The reason why I mentioned #527 is that if we solve that one, we can also check the validity of this PR. |
Ok, a small update to this:
Let me know if there are some changes that need to be done regarding tests(if not I will continue adding them in the same manner if I have time) docs for the future :D |
Signed-off-by: Trial97 <[email protected]>
The
require
statements should be dynamic in order to place this project in another folder other than the root config folder