Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

basic SASL DIGEST-MD5 support #473

Closed
wants to merge 1 commit into from
Closed

Conversation

nelapsi13
Copy link

added very basic support for SASL DIGEST-MD5 bind
basically, bind flow should be smth like

  1. run bind_sasl_digest_md5_step1()
  2. parse SASL challenge from step1 (at least nonce is needed)
  3. generate SASL challenge_response (there is an example in lib/messages/sasl_digest_md5_bind_request.js )
  4. run bind_sasl_digest_md5_step1(challenge_response)

Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can you add some unit tests for this new functionality?
  2. Please update the documentation: https://github.com/ldapjs/node-ldapjs/tree/ad451edc18d7768c3ddee1a1dd472d2bbafdae5e/docs

Also, please rebase onto the next branch.

This was referenced Aug 26, 2019
@jsumners jsumners added the closed-for-v2 Issues that were closed at the release of v2.0.0 but may still need to be addressed. label May 31, 2020
@jsumners jsumners closed this May 31, 2020
@sand123
Copy link

sand123 commented Jan 12, 2021

Any chances to see this functionality? I've stuck in SASL bind requirements

@jsumners
Copy link
Member

If you would like to open a new pull request to add this functionality, you are welcome do so. Remember to add unit tests.

@binhphi109
Copy link

Are there any updates regarding this feature, or any plan?

@ldapjs ldapjs locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed-for-v2 Issues that were closed at the release of v2.0.0 but may still need to be addressed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants