Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing lowering for function calls with noreturn args #3853

Open
kinke opened this issue Oct 18, 2021 · 1 comment
Open

Missing lowering for function calls with noreturn args #3853

kinke opened this issue Oct 18, 2021 · 1 comment

Comments

@kinke
Copy link
Member

kinke commented Oct 18, 2021

dlang/dmd#13179 added that lowering to DMD's glue layer; it should probably be lowered in the frontend instead.
kinke added a commit to ldc-developers/dmd-testsuite that referenced this issue Oct 18, 2021
@kinke
LDC: Disable new runnable/noreturn2.d for now
4c25bbf 
See ldc-developers/ldc#3853.
@kinke
Copy link
Member Author

kinke commented Oct 18, 2021 •
edited
Loading

Argh, and such 0-sized parameters (currently lowered to void in IR) need to be handled for the function declaration/definition too... what a mess.

kinke added a commit to ldc-developers/druntime that referenced this issue Oct 18, 2021
@kinke
[LDC] core.demangle: Disable new noreturn-related tests for now
8e135b4 
See ldc-developers/ldc#3853.
kinke added a commit to kinke/ldc that referenced this issue Oct 18, 2021
@kinke
Disable some new tests using functions with noreturn params
2370250 
See ldc-developers#3853.
kinke added a commit that referenced this issue Oct 19, 2021
@kinke
Merge upstream stable (#3852)
6a240b6 
* Merge upstream stable (dlang/dmd@58e4db9880)

* Support noreturn-typed global variables

By representing them as a dummy 0 byte.

Fixes a recent addition in dmd-testsuite's compilable/noreturn1.d.

* Disable some new tests using functions with noreturn params

See #3853.

* dmd-testsuite: Slightly adapt new dshell/dll_cxx.d

* Merge upstream stable (dlang/dmd@501d47b9ae)

* Update v1.28.0 changelog

* Fix unused-variable warning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kinke