OS X - default OS to macosx instead of darwin #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On OS X, the OS in Triple should be macosx, not darwin. This is not comprehensive like clang which has a bunch of darwin to other OS translation rules, but since only Darwin target currently supported is OS X, this does the job.
|
Why doesn't core.thread fail in Travis CI for OS X RELEASE? It must not be using multiple real CPUs? I still always get a SEGV due to #666 when I run tests against master. BTW, I'd like to fix that with ldc-developers/druntime#30 if somebody has the time to review. The PR is old and may need some updates. It would probably also work for Windows and the |
dnadlinger
added a commit
that referenced
this pull request
Nov 16, 2015
OS X - default OS to macosx instead of darwin
|
Oh, looks like this also got rid of the linker bug for Travis OSX? |
This was referenced Jul 10, 2017
ihnorton
added a commit
to ihnorton/julia
that referenced
this pull request
Jul 10, 2017
ararslan
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Jul 11, 2017
jeffwong
pushed a commit
to jeffwong/julia
that referenced
this pull request
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not mean to be the end all as other darwin targets are coming along. But this makes everything better with Xcode 7. In particular, OS X ld in Xcode 7 warns when default LLVM triple with OS darwin is used because the darwin default version (x86_64-apple-darwin14.5.0 on my box) is greater than OS X version. More work has to be done for specifying OS min versions and such. Hope this is ok for now.
For background: http://forum.dlang.org/post/[email protected]