Test #3848 + #3850 #3858
Closed
Test #3848 + #3850 #3858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, use the object file generated by compiling shared druntime directly. By using the `@hidden` UDA in that module, `-fvisibility=public` isn't a problem anymore. We also end up with a 32-bit `ldc_rt.dso.o` for MULTILIB=ON this way.
This should help on Windows if those tools aren't available/in PATH.
Mainly, avoid running the MSan lit-tests with shared default libs, which apparently regressed with the rt.dso introduction with older LLVM/MSan versions - for GH Actions, at least with LLVM v8 and v9; v11 and v12 do work.
I hope the issues with old bfd aren't really a thing anymore. The main reason is that the user might have set LLD as default `/usr/bin/ld` symlink, and LDC not using it by default isn't intuitive. And LLD can be significantly faster than gold.
bfd cannot be used for linking the final compiler with LTO, it rejects bitcode .a libs.
As bfd doesn't support lib{druntime,phobos}-ldc-lto.a libs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.