Upgrade frontend & libs to v2.100.0+ #3970

kinke · 2022-04-26T21:04:45Z

No description provided.

….cpp

…epo root

…d some more

So that it doesn't increase the overall struct size.

This fixes a bunch of importC dmd-testsuite tests.

Fixes dmd-testsuite's runnable/test22974.c.

…portC zero-init Fixes dmd-testsuite's runnable/test22994.c.

This fixes a bunch of importC dmd-testsuite tests.

Fixes dmd-testsuite's compilable/test22929.c.

Fixes dmd-testsuite's compilable/test22955.c.

…r importC AST) Fixing failing LDC assertions.

This fixes linker errors about a missing ModuleInfo section when ldc_rt.dso.o is pulled in for BUILD_SHARED_LIBS=ON builds (with implicit -link-defaultlib-shared).

kinke · 2022-05-02T11:09:38Z

The only remaining problem is a sanitizers/asan_fakestack_GC.d lit-test regression. core.thread wasn't touched; failing

ldc/tests/sanitizers/asan_fakestack_GC.d

Line 44 in 490bdcb

assert(GC.stats.usedSize == initialSize);

might show a GC regression (the GC has been worked on).

Edit: Unlikely, as the test works fine without SupportSanitizers.

Conflicts: runtime/CMakeLists.txt

E.g., for v2.100.0: libphobos2-ldc-shared.so -> libphobos2-ldc-shared.so.100 -> libphobos2-ldc-shared.so.100.0

kinke · 2022-05-12T14:33:21Z

@JohanEngelen: Can you be bothered to look at the test regression? It's of no priority to me, so I'd probably just disable it to move forward.

kinke · 2022-05-12T20:29:28Z

[That same test just failed in another PR: https://cirrus-ci.com/task/6100113155162112]

I've seen this fail twice already.

JohanEngelen · 2022-05-13T11:27:02Z

The only remaining problem is a sanitizers/asan_fakestack_GC.d lit-test regression. core.thread wasn't touched; failing

ldc/tests/sanitizers/asan_fakestack_GC.d

Line 44 in 490bdcb

assert(GC.stats.usedSize == initialSize);

might show a GC regression (the GC has been worked on).
Edit: Unlikely, as the test works fine without SupportSanitizers.

The test_nulling_triggers_collection function can be removed.

ldc/tests/sanitizers/asan_fakestack_GC.d

Line 29 in 490bdcb

void test_nulling_triggers_collection()

It is testing GC functionality (which is not required to collect unused memory), and not fakestack functionality (done by test_non_null_does_not_trigger_collection).

Edit: I added test_nulling_triggers_collection to verify the delta of null vs non-null. If test_non_null_does_not_trigger_collection passes, it could either be that fakestack is working correctly OR that GC just does not collect (hiding fakestack bug).

kinke · 2022-05-15T17:58:42Z

The test_nulling_triggers_collection function can be removed. [...] It is testing GC functionality (which is not required to collect unused memory), and not fakestack functionality (done by test_non_null_does_not_trigger_collection).

Hmm, I still find it somewhat worrying that it now apparently never collects the unreferenced garbage anymore; no idea how the fakestack works, but is there a chance the nullified pointer is still non-nullified in some GC-scanned memory block? And would that be considered legal?

kinke added 13 commits April 26, 2022 23:01

Upgrade frontend & libs to v2.100.0-beta.1+ (dlang/dmd@c0cff59c79)

b7b8e59

Adapt lit-test semantic/dcompute.d to obsolete delete keyword

8b3b566

Initialize new TargetC fields

a3716c0

druntime: Add newly required return attribute in rt.sections_android

597e67c

Predefine new version D_Invariants

c555700

dmd-testsuite: Adapt expected output of fail_compilation/write_error.d

926d301

dmd-testsuite: Restore mini-adaption of runnable_cxx/extra-files/cppb…

ab5f33b

….cpp

dmd-testsuite: Add .gitattributes for strict EOLs from upstream DMD r…

a755317

…epo root

dmd-testsuite: Adapt expected output of fail_compilation/write_error.…

7888837

…d some more

Optimize placement of LDC-specific Scope::emitInstrumentation field

a183154

So that it doesn't increase the overall struct size.

codegen: Support EqualExp with non-bool type (for importC AST)

e4878f2

This fixes a bunch of importC dmd-testsuite tests.

importC: Fix mangling of extern variable inside function

dab538f

Fixes dmd-testsuite's runnable/test22974.c.

Pass isCfile parameter for all defaultInit() calls, for some extra im…

4b1f551

…portC zero-init Fixes dmd-testsuite's runnable/test22994.c.

kinke force-pushed the merge-2.100 branch from 7289d4f to 4b1f551 Compare April 30, 2022 17:54

kinke added 4 commits April 30, 2022 20:55

druntime: Define __va_list in importC's __builtins.di

f892dd7

This fixes a bunch of importC dmd-testsuite tests.

Handle importC SymOffExp quirk

b3e7fc8

Fixes dmd-testsuite's compilable/test22929.c.

druntime: Add missing symbols in importC's __builtins.di

952e63b

Fixes dmd-testsuite's compilable/test22955.c.

codegen: Support {Not,Logical,Identity,Cmp}Exp with non-bool type (fo…

be20833

…r importC AST) Fixing failing LDC assertions.

kinke force-pushed the merge-2.100 branch from 7384bb7 to be20833 Compare April 30, 2022 21:47

dmd-testsuite: Enforce -defaultlib= (no druntime/Phobos) for *.c tests

523bcdb

This fixes linker errors about a missing ModuleInfo section when ldc_rt.dso.o is pulled in for BUILD_SHARED_LIBS=ON builds (with implicit -link-defaultlib-shared).

kinke force-pushed the merge-2.100 branch from b1324d5 to 523bcdb Compare May 1, 2022 00:53

kinke added 3 commits May 1, 2022 02:56

[add changelog entry]

098c2b0

Merge upstream stable (dlang/dmd@84af0a8586)

8cbb273

Work around bug with LDC < v1.14 host compilers

4ca4716

kinke added 5 commits May 5, 2022 16:38

Merge upstream stable (dlang/dmd@de56f38c3c)

81d2178

Merge upstream stable (dlang/dmd@71512901f7)

1fb01cf

Adapt glue layer to renamed/changed Declaration::linkage

be9d581

Merge remote-tracking branch 'origin/master' into merge-2.100

3426418

Conflicts: runtime/CMakeLists.txt

[add lost CMakeLists.txt changes]

aa6dfe8

CMake: Tweak library versioning symlink scheme

c63b52a

E.g., for v2.100.0: libphobos2-ldc-shared.so -> libphobos2-ldc-shared.so.100 -> libphobos2-ldc-shared.so.100.0

kinke marked this pull request as ready for review May 7, 2022 10:27

kinke added 2 commits May 12, 2022 14:15

Merge upstream stable (dlang/dmd@5233596cf8)

99c9f6d

Merge remote-tracking branch 'origin/master' into merge-2.100

4dc0264

kinke added 4 commits May 12, 2022 22:37

Merge remote-tracking branch 'origin/master' into merge-2.100

e2ba821

Disable lit-test sanitizers/asan_fakestack_GC.d for now

ea75a5c

[merge fixup]

f945b2e

GH Actions: Work around trivial, weird & sporadic issue on Windows

bb5fa60

I've seen this fail twice already.

kinke added 3 commits May 15, 2022 13:40

Merge upstream stable (dlang/dmd@a53934d18e)

0c5a122

Bump bundled dub, dlang tools and reggae to latest versions

19e0003

Bump mimalloc to latest stable version

24f5af4

kinke changed the title ~~Upgrade frontend & libs to early v2.100.0~~ Upgrade frontend & libs to v2.100.0+ May 15, 2022

kinke merged commit 73e8414 into ldc-developers:master May 16, 2022

kinke deleted the merge-2.100 branch May 16, 2022 10:39

kinke mentioned this pull request May 16, 2022

Re-enable lit-test sanitizers/asan_fakestack_GC.d #3983

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade frontend & libs to v2.100.0+ #3970

Upgrade frontend & libs to v2.100.0+ #3970

kinke commented Apr 26, 2022

kinke commented May 2, 2022 •

edited

Loading

kinke commented May 12, 2022

kinke commented May 12, 2022 •

edited

Loading

JohanEngelen commented May 13, 2022 •

edited

Loading

kinke commented May 15, 2022

Upgrade frontend & libs to v2.100.0+ #3970

Upgrade frontend & libs to v2.100.0+ #3970

Conversation

kinke commented Apr 26, 2022

kinke commented May 2, 2022 • edited Loading

kinke commented May 12, 2022

kinke commented May 12, 2022 • edited Loading

JohanEngelen commented May 13, 2022 • edited Loading

kinke commented May 15, 2022

kinke commented May 2, 2022 •

edited

Loading

kinke commented May 12, 2022 •

edited

Loading

JohanEngelen commented May 13, 2022 •

edited

Loading