Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update-dmd-rewrite.sh script #4274

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

kinke
Copy link
Member

@kinke kinke commented Nov 20, 2022

See #4245.

@kinke
Copy link
Member Author

kinke commented Nov 20, 2022

For local testing, assuming you are in the parent dir of the ldc clone:

$ cp -R ldc ldc-mono-vanilla
$ INITIALIZE=1 ldc/tools/update-dmd-rewrite.sh

The ldc-mono dir then contains a lot of new tags (incl. dmd-rewrite-first-merged-dmd-druntime-with-ldc-druntime-patches) and the dmd-rewrite-{master,stable} branches. [Rewritten dmd.tmp is temporarily kept.]

To simulate an update, re-run without INITIALIZE=1 and with commented-out rm -rf ../ldc-mono && cp -R ../ldc-mono-vanilla ../ldc-mono line.

@JohanEngelen
Copy link
Member

For local testing, assuming you are in the parent dir of the ldc clone:

$ cp -R ldc ldc-mono-vanilla
$ INITIALIZE=1 ldc/tools/update-dmd-rewrite.sh

The ldc-mono dir then contains a lot of new tags (incl. dmd-rewrite-first-merged-dmd-druntime-with-ldc-druntime-patches) and the dmd-rewrite-{master,stable} branches. [Rewritten dmd.tmp is temporarily kept.]

To simulate an update, re-run without INITIALIZE=1 and with commented-out rm -rf ../ldc-mono && cp -R ../ldc-mono-vanilla ../ldc-mono line.

Can you add all this info to the script file?

@kinke kinke marked this pull request as ready for review November 25, 2022 01:50
@kinke
Copy link
Member Author

kinke commented Nov 25, 2022

It should now be safe to execute the script for local testing (edit: discard the previous instructions above, just run tools/update-dmd-rewrite.sh). DMD master has gotten new commits since the initial rewrite, so when executing the script now, it should update the dmd-rewrite-master branch. If you just want to check without actual pushing, use git push --dry-run … in line 101:

…
+ git push --dry-run --tags ldc dmd-rewrite-master dmd-rewrite-stable
To github.com:ldc-developers/ldc.git
   ab0d4ab2e..9b3ea5028  dmd-rewrite-master -> dmd-rewrite-master
…

@kinke kinke merged commit a912d59 into ldc-developers:master Jan 15, 2023
@kinke kinke deleted the update-dmd-rewrite branch January 15, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants