Add "Posix" global version conditional for Emscripten targets #4738
Conversation
|
I managed to build ldc from source, and i managed to produce a wasm file with that:
import std;
extern(C) void _start()
{
writeln("hi");
}I'll try to do the same with druntime and phobos |
| // Emscripten reimplements Posix APIs | ||
| VersionCondition::addPredefinedGlobalIdent("linux"); | ||
| VersionCondition::addPredefinedGlobalIdent("Posix"); | ||
| VersionCondition::addPredefinedGlobalIdent("CRuntime_Musl"); |
There was a problem hiding this comment.
is this correct? Musl? that is more than just posix.
There was a problem hiding this comment.
emscripten uses musl, musl is POSIX compliant
There was a problem hiding this comment.
Hmm interesting. Do you have a link to confirm this? I found emscripten-core/emscripten#13006 which seems to support this.
The proper place to add the musl-compatible predefined versions is
Lines 921 to 923 in dd0ff1e
| VersionCondition::addPredefinedGlobalIdent("linux"); | ||
| VersionCondition::addPredefinedGlobalIdent("Posix"); | ||
| VersionCondition::addPredefinedGlobalIdent("CRuntime_Musl"); | ||
| VersionCondition::addPredefinedGlobalIdent("X86_Any"); |
| VersionCondition::addPredefinedGlobalIdent("WebAssembly"); | ||
| if (triple.getOS() == llvm::Triple::Emscripten) { | ||
| // Emscripten reimplements Posix APIs | ||
| VersionCondition::addPredefinedGlobalIdent("linux"); |
There was a problem hiding this comment.
linux probably also incorrect?
|
Superseded by #4750. |
I just had this thought after seeing this: https://forum.dlang.org/post/[email protected]
Haven't tested yet, but i submit the PR otherwise i'll forget
And i can't compile ldc from source:
cmake -G Ninja ../ -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=$PWD/../install-ldc