Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add slice flags #23

Merged
merged 7 commits into from
May 9, 2024
Merged

add slice flags #23

merged 7 commits into from
May 9, 2024

Conversation

zkep
Copy link
Contributor

@zkep zkep commented Apr 30, 2024

In practice, array-type fields are often used, and they should be supported, and perhaps not necessarily required

@leaanthony
Copy link
Owner

Thanks so much for this! This feature has been on my mind for a while so this is awesome! It may take me a while to review, so please be patient 🙏

@leaanthony
Copy link
Owner

I've pushed a couple of changes, let me know your thoughts 👍

@zkep
Copy link
Contributor Author

zkep commented May 3, 2024

I've pushed a couple of changes, let me know your thoughts 👍

Looks good, gets better !!!

@leaanthony
Copy link
Owner

Is this ready to go now?

@zkep
Copy link
Contributor Author

zkep commented May 9, 2024

Is this ready to go now?

yes!

@leaanthony leaanthony merged commit 9a039b7 into leaanthony:master May 9, 2024
4 checks passed
@leaanthony
Copy link
Owner

Thanks for this! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants