Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The literal year overdue merger... #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

abaez
Copy link

@abaez abaez commented Nov 13, 2016

Hey,

A little while ago, I told you I was going to do a PR for the merger of this Textadept module with my own. After 1.42 Venus days, I have finally done just that! cries

I should really track time in Earth days...

@leafo
Copy link
Owner

leafo commented Nov 22, 2016

the current lexer is written in moonscript, are you replacing it with a lua version? You didn't delete the moon one. I'd prefer to keep the thing written in moonscript if possible but that might be outside the scope of your changes. Do you know what the differences are?

@abaez
Copy link
Author

abaez commented Nov 22, 2016

Hey,

Sorry about that. I actually didn’t focus on the moonscript version
and instead tried to parry with the lua one. You’re right. It was
outside my scope. The thought process was to have lua version merged,
thus going ahead to propose its acceptance into Textadept’s main repo.
In doing so, I can go ahead and close out my version of the module, or
at the very least, redirect to your version. I would like to know what
you think though. Should I go ahead and transpose the work to
moonscript? It would not be difficult to do so. Your language is easy
enough to work with any how. :)
On Tue, Nov 22, 2016, at 02:03 AM, leaf wrote:

the current lexer is written in moonscript, are you replacing it with
a lua version? You didn't delete the moon one. I'd prefer to keep the
thing written in moonscript if possible but that might be outside the
scope of your changes. Do you know what the differences are?
— You are receiving this because you authored the thread. Reply to
this email directly, view it on GitHub[1], or mute the thread[2].

Links:

  1. The literal year overdue merger... #2 (comment)
  2. https://github.com/notifications/unsubscribe-auth/ABVq7qkRGIq_qk-xnn57036O9sgMxAnDks5rApPWgaJpZM4KwmsX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants