-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: check if return type is scalar before link field binded #70
Merged
fahimalizain
merged 2 commits into
leam-tech:ROMMAN-T-289-kick-default-resolver
from
e-lobo:link-field-bind-resolver-enhancement
Aug 25, 2022
Merged
refactor: check if return type is scalar before link field binded #70
fahimalizain
merged 2 commits into
leam-tech:ROMMAN-T-289-kick-default-resolver
from
e-lobo:link-field-bind-resolver-enhancement
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-resolver-enhancement
fahimalizain
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well 👍🏼
leambot
pushed a commit
that referenced
this pull request
Jan 14, 2023
ROMMAN-T-433 | tests: Update DocumentResolver Tests tests: fix test_deleted_doc_resolution Merge branch 'ROMMAN-T-289-kick-default-resolver' into ROMMAN-T-433-document-resolver-tests Merge branch 'ROMMAN-T-289-kick-default-resolver' into ROMMAN-T-433-document-resolver-tests tests: Update DocumentResolver Tests Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-368 Merged-by: Fahim Ali Zain <[email protected]> test: fix TestGetAllowedFieldNameForDocType fix: Replace db.sql with get_all in child_table_loader chore: types fix: Clear dataloader cache post each batch load use new graphql-sync-dataloaders package (#81) * refactor: use graphql-sync-dataloader package * refactor: update package graphql-sync-dataloader Merge branch 'master' into ROMMAN-T-289-kick-default-resolver [ROMMAN-T-521] GQL Dataloader: Raise Perm Error on GQLNonNull Permlevel Restricted Fields fix: check for GraphQLNonNull fix: use default_field_resolver from graphql fix: refactored perm checks fix: Raise Perm Error on GQLNonNull Permlevel Restricted Fields Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-214 Merged-by: Fahim Ali Zain <[email protected]> feat: pre load schema's utility (#78) fix: cache get_allowed_fieldnames_for_doctype at the request level fix: default_fields link fields like owner fix: get_allowed_fieldnames_for_doctype on plain child-doctype support refactor: check if return type is scalar before link field binded (#70) feat: implement select field resolver Co-authored-by: Abadulrehman <[email protected]> Merge-request: ROMMAN-MR-196 Merged-by: Fahim Ali Zain <[email protected]> fix: Setup GQLType.doctype resolver manually feat: Translations Support fix: remove redundant resolver check Merge branch 'ROMMAN-T-289-kick-default-resolver' into ROMMAN-T-481-translations feat: Translations Support Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-177 Merged-by: Fahim Ali Zain <[email protected]> Merge branch 'master' into ROMMAN-T-289-kick-default-resolver feat: Introduce hook 'doctype_resolver_processors' Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-178 Merged-by: Fahim Ali Zain <[email protected]> fix: Reduced no. of iterations in default schema binding fix: DeferredValue support for Mutations (#67) feat: Field Level Perms (#66) * feat: Field Level Perms * fix: keywords in field names feat: Basic Perms for new Resolvers fix: Use get_list in doc-dataloader feat: Basic Perms for new resolvers Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-126 Merged-by: Fahim Ali Zain <[email protected]> fix: removed unused code fix: remove deprecated code fix: support parent link fields fix: deferred_list callback list fix: CursorPaginator Select Fields feat: DataLoader [WIP] feat: Experiments Co-authored-by: Abadulrehman <[email protected]> Co-authored-by: Elton Lobo <[email protected]> Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-119 Merged-by: Fahim Ali Zain <[email protected]>
fahimalizain
added a commit
that referenced
this pull request
Jan 30, 2023
* [WIP] feat: Experiments * feat: DataLoader * fix: CursorPaginator Select Fields * fix: deferred_list callback list * fix: support parent link fields * fix: remove deprecated code * fix: removed unused code * feat: Basic Perms for new Resolvers fix: Use get_list in doc-dataloader feat: Basic Perms for new resolvers Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-126 Merged-by: Fahim Ali Zain <[email protected]> * feat: Field Level Perms (#66) * feat: Field Level Perms * fix: keywords in field names * fix: DeferredValue support for Mutations (#67) * fix: Reduced no. of iterations in default schema binding * feat: Introduce hook 'doctype_resolver_processors' Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-178 Merged-by: Fahim Ali Zain <[email protected]> * feat: Translations Support fix: remove redundant resolver check Merge branch 'ROMMAN-T-289-kick-default-resolver' into ROMMAN-T-481-translations feat: Translations Support Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-177 Merged-by: Fahim Ali Zain <[email protected]> * fix: Setup GQLType.doctype resolver manually * feat: implement select field resolver Co-authored-by: Abadulrehman <[email protected]> Merge-request: ROMMAN-MR-196 Merged-by: Fahim Ali Zain <[email protected]> * refactor: check if return type is scalar before link field binded (#70) * fix: get_allowed_fieldnames_for_doctype on plain child-doctype support * fix: default_fields link fields like owner * fix: cache get_allowed_fieldnames_for_doctype at the request level * refactor: query only user requested fields * feat: pre load schema's utility (#78) * [ROMMAN-T-521] GQL Dataloader: Raise Perm Error on GQLNonNull Permlevel Restricted Fields fix: check for GraphQLNonNull fix: use default_field_resolver from graphql fix: refactored perm checks fix: Raise Perm Error on GQLNonNull Permlevel Restricted Fields Co-authored-by: Fahim Ali Zain <[email protected]> Merge-request: ROMMAN-MR-214 Merged-by: Fahim Ali Zain <[email protected]> * use new graphql-sync-dataloaders package (#81) * refactor: use graphql-sync-dataloader package * refactor: update package graphql-sync-dataloader * refactor: fetch required fields * refactor: suppress JMESPathTypeError * refactor: move dedicated functions * refactor: use is_introspection_key wrapper * feat: get fields selected from child table query * feat: get fields selected from doctype dataloader * refactor: support use of aliases ie dataloaders re-used in query * refactor: extract fields from all field nodes * refactor: always query name cursor paginator fields * refactor: query name and parent for child tables * refactor: return of_type * refactor: use merge deep * refactor: remove unused imports * refactor: type error if extra_fields empty * refactor: get_doctype_requested_fields wrapper * refactor: query name always * refactor: cache fields in get_doctype_requested_fields * refactor: add parent doctype kwarg to get_fields_cursor_paginator * refactor: file names --------- Co-authored-by: Fahim Ali Zain <[email protected]> Co-authored-by: Abadulrehman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.