Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster repo loading #63

Merged
merged 9 commits into from
Sep 24, 2023
Merged

Faster repo loading #63

merged 9 commits into from
Sep 24, 2023

Conversation

yangky11
Copy link
Member

No description provided.

@yangky11 yangky11 changed the title Faster re loading Faster repo loading Sep 16, 2023
@yangky11 yangky11 mentioned this pull request Sep 16, 2023
Merged
josojo
josojo approved these changes Sep 16, 2023
View reviewed changes
Copy link
Contributor

@josojo josojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce, thanks for cleaning up the PR with better variable names and the nice to_xml_path function.

I think you just forgot a i++, otherwise ready to merge

src/lean_dojo/data_extraction/traced_data.py Show resolved Hide resolved
@yangky11
Copy link
Member Author

Running unit tests and will merge if everything is good.

@yangky11 yangky11 merged commit 59937fa into main Sep 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josojo josojo josojo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangky11 @josojo