Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor message patch #648

Merged
merged 2 commits into from
May 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AVOS/LeanCloudObjcTests/BaseTestCase.swift
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ extension BaseTestCase {
}

func delay(seconds: TimeInterval = 3.0) {
print("\n------\nwait \(seconds) seconds.\n------\n")
let exp = expectation(description: "delay \(seconds) seconds.")
exp.isInverted = true
wait(for: [exp], timeout: seconds)
Expand Down
10 changes: 10 additions & 0 deletions AVOS/LeanCloudObjcTests/IMClientTestCase.swift
Original file line number Diff line number Diff line change
Expand Up @@ -206,4 +206,14 @@ class LCIMClientDelegator: NSObject, LCIMClientDelegate {
func conversation(_ conversation: LCIMConversation, didReceive message: LCIMTypedMessage) {
didReceiveTypedMessage?(conversation, message)
}

var messageHasBeenUpdated: ((LCIMConversation, LCIMMessage, LCIMMessagePatchedReason?) -> Void)?
func conversation(_ conversation: LCIMConversation, messageHasBeenUpdated message: LCIMMessage, reason: LCIMMessagePatchedReason?) {
messageHasBeenUpdated?(conversation, message, reason)
}

var messageHasBeenRecalled: ((LCIMConversation, LCIMRecalledMessage, LCIMMessagePatchedReason?) -> Void)?
func conversation(_ conversation: LCIMConversation, messageHasBeenRecalled message: LCIMRecalledMessage, reason: LCIMMessagePatchedReason?) {
messageHasBeenRecalled?(conversation, message, reason)
}
}
71 changes: 71 additions & 0 deletions AVOS/LeanCloudObjcTests/IMMessageTestCase.swift
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,77 @@ class IMMessageTestCase: RTMBaseTestCase {
delegator3.reset()
delegator4.reset()
}

func testUpdateAndRecallMessage() {
guard let client1 = newOpenedClient(clientIDSuffix: "1"),
let client2 = newOpenedClient(clientIDSuffix: "2") else {
XCTFail()
return
}

let delegator1 = LCIMClientDelegator()
client1.delegate = delegator1
let delegator2 = LCIMClientDelegator()
client2.delegate = delegator2
var conv: LCIMConversation?

expecting { exp in
client1.createConversation(withClientIds: [client2.clientId]) { conversation, error in
if let conversation = conversation {
conv = conversation
exp.fulfill()
} else {
XCTAssertNil(error)
}
}
}

let oldMessage = LCIMTextMessage(text: "old")
expecting(description: "send message", count: 2) { exp in
delegator2.didReceiveTypedMessage = { conversation, message in
exp.fulfill()
}
conv?.send(oldMessage, callback: { succeeded, error in
if succeeded {
exp.fulfill()
} else {
XCTAssertNil(error)
}
})
}

delay()

let newMessage = LCIMTextMessage(text: "new")
expecting(description: "update message", count: 2) { exp in
delegator2.messageHasBeenUpdated = { conversation, message, _ in
exp.fulfill()
}
conv?.update(oldMessage, toNewMessage: newMessage, callback: { succeeded, error in
if succeeded {
exp.fulfill()
} else {
XCTAssertNil(error)
}
})
}

delay()

expecting(description: "recall message", count: 2) { exp in
delegator2.messageHasBeenRecalled = { conversation, message, _ in
exp.fulfill()
}
conv?.recall(newMessage, callback: { succeeded, error, recalledMessage in
if succeeded {
XCTAssertNotNil(recalledMessage)
exp.fulfill()
} else {
XCTAssertNil(error)
}
})
}
}
}

extension IMMessageTestCase {
Expand Down
Loading