refactor: message media type #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zapcannon87
commented
Dec 28, 2021
| @@ -735,6 +735,7 @@ class LCIMConversationTestCase: RTMBaseTestCase { | |||
| conv.read() | |||
| } | |||
| wait(for: [allReadExp], timeout: timeout) | |||
| delegator.reset() | |||
There was a problem hiding this comment.
跑全量测试，这里出现一个「多次调用 exp」的异常，所以加了一个 reset
zapcannon87
commented
Dec 28, 2021
| double width = [metaData[@"width"] doubleValue]; | ||
| double height = [metaData[@"height"] doubleValue]; | ||
| if (!(width > 0 && height > 0)) { | ||
| if (typedMessage.mediaType == LCIMMessageMediaTypeImage) { |
There was a problem hiding this comment.
改了 LCIMMessageMediaType 后，不知道为什么 switch 识别不了了，遂改成 if-else 模式
harryphone
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.