Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onWindowEnterFullScreen/onWindowLeaveFullScreen not work any more on windows #396

Closed
nonebyte opened this issue Sep 19, 2023 · 1 comment · Fixed by #409
Closed

onWindowEnterFullScreen/onWindowLeaveFullScreen not work any more on windows #396

nonebyte opened this issue Sep 19, 2023 · 1 comment · Fixed by #409

Comments

@nonebyte
Copy link

ver 0.3.6 fullscreen callback onWindowEnterFullScreen/onWindowLeaveFullScreen not work any more, when fullscreen status change only onWindowMaximize/onWindowUnmaximize called .
@damywise
Copy link
Contributor

damywise commented Oct 9, 2023 •
edited
Loading

Sorry, yes, I can definitely reproduce this unacceptable behavior in the example app.
I will submit a pull request (PR) soon.

@damywise damywise mentioned this issue Oct 9, 2023
Merged
damywise pushed a commit to damywise/window_manager that referenced this issue Oct 9, 2023
@wisetarman
fix leanflutter#396: (windows) fullscreen/unfullscreen events, disabl…
a96f5a3 
…e minimize on fullscreen

- Fixed a bug where the newest implementation of fullscreen/unfullscreen broke the window listener events.
- Disables minimize when window is fullscreen. This mimics the behavior of Chromium.
lijy91 pushed a commit that referenced this issue Jan 28, 2024
@wisetarman
fix #396: (windows) fullscreen/unfullscreen events, disable minimize …
b3b1417 
…on fullscreen (#409)

- Fixed a bug where the newest implementation of fullscreen/unfullscreen broke the window listener events.
- Disables minimize when window is fullscreen. This mimics the behavior of Chromium.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nonebyte @damywise