Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Fix #112: Add visibleSize and visiblePosition #113

Merged
merged 3 commits into from
Apr 2, 2022
Merged

[Windows] Fix #112: Add visibleSize and visiblePosition #113

merged 3 commits into from
Apr 2, 2022

Conversation

damywise
Copy link
Contributor

@damywise damywise commented Apr 2, 2022 •
edited
Loading

  • Add visibleSize and visiblePosition for getPrimaryDisplay

@damywise damywise changed the title [Windows] Fix #112: Return work area instead of display area [Windows] Fix #112 : Return work area instead of display area Apr 2, 2022
@damywise damywise changed the title [Windows] Fix #112 : Return work area instead of display area [Windows] Fix #112: Return work area instead of display area Apr 2, 2022
@lijy91
Copy link
Member

lijy91 commented Apr 2, 2022

Should keep size and add visibleSize field.

window_manager/macos/Classes/WindowManager.swift

Lines 476 to 479 in 875a617

let visibleSize: NSDictionary = [
"width": screen.visibleFrame.width,
"height": screen.visibleFrame.height,
]

@damywise
Copy link
Contributor Author

damywise commented Apr 2, 2022

Will do

@damywise damywise changed the title [Windows] Fix #112: Return work area instead of display area [Windows] Fix #112: Add visibleSize Apr 2, 2022
@damywise
Copy link
Contributor Author

damywise commented Apr 2, 2022

Todo: Add visiblePosition

@damywise damywise changed the title [Windows] Fix #112: Add visibleSize [Windows] Fix #112: Add visibleSize and visiblePosition Apr 2, 2022
@damywise
Copy link
Contributor Author

damywise commented Apr 2, 2022

Done, I think

@lijy91 lijy91 merged commit 2b0ad07 into leanflutter:main Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damywise @lijy91 @wisetarman