feat: setTitleBarStyle() restores window frame on Linux #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if it would be better to separate these completely, right now they are trying to do 2 things at once (titlebar/frame). Maybe change Simplifies, and resolves conflicts. |
|
I'm inclined to agree with this |
|
LGTM |
obiwanzenobi
pushed a commit
to obiwanzenobi/window_manager
that referenced
this pull request
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on Linux using
setAsFramelesscan't be undone; with this change usingsetTitleBarStyle(TitleBarStyle.normal)will also restore the window frame.Follows the same sort of resolution as #103