Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows] Better fullscreen implementation #367

Merged
merged 3 commits into from
Aug 27, 2023
Merged

[Windows] Better fullscreen implementation #367

merged 3 commits into from
Aug 27, 2023

Conversation

damywise
Copy link
Contributor

@damywise damywise commented Jul 20, 2023 •
edited
Loading

Uses a modified method suggested by this comment by @alexmercerind, which in general reduces flicker when going to full screen and just behaves more predictable.

Todo:

  • Remove unused code.
  • Add comments .

How setFullScreen(true) works now

  1. Native window title bar is removed.
  2. Remove/hide custom title bar widget (Developers should do this themselves).
  3. Borders (including the rounded corners) are removed
  4. Window is maximized to fit the whole screen.
  5. Prevent the user from resizing the window (disables startResizing())
  6. Prevent the user from dragging/moving the window (disables startDragging())

@damywise damywise marked this pull request as ready for review July 28, 2023 09:21
@damywise
Copy link
Contributor Author

@lijy91 I removed the lines which modifies GWL_EXSTYLE and don't find any errors. Do you know if those do something?

@damywise
Copy link
Contributor Author

@alexmercerind Sorry for the wait, apparently it took longer than 2 weeks. Can you try this PR and see if this fits your requirement?

@damywise damywise changed the title Better fullscreen implementation [Windows] Better fullscreen implementation Aug 10, 2023
@alexmercerind alexmercerind mentioned this pull request Aug 15, 2023
Closed
@lijy91
Copy link
Member

lijy91 commented Aug 27, 2023

LGTM

@lijy91 lijy91 merged commit 245f855 into leanflutter:main Aug 27, 2023
fufesou pushed a commit to fufesou/window_manager that referenced this pull request Sep 21, 2023
@wisetarman @fufesou
[Windows] Better fullscreen implementation (leanflutter#367)
2df66bb 
* Better fullscreen implementatoin

* Add comments and remove unused lines

* Fix stupid mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damywise @lijy91 @wisetarman