Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows, window size, fullscree & maximized #477

Merged

Conversation

fufesou
Copy link
Contributor

@fufesou fufesou commented Aug 7, 2024

In the default example, the window height is incorrect when maximized.

Reproduce steps

Windows -> Display settings -> Scale (any value other than 100%)

image

Win11, scale 150%, 2160x1440, window_manager as an example (same logic).

  1. cd example && flutter run -d windows
  2. Find the output like The Flutter DevTools debugger and profiler on Windows is available at: http://127.0.0.1:9105?uri=http://127.0.0.1:65189/_rHWjbz1MZA=/, open the link.
  3. Back the the example window, maxmize the window.
  4. Check the window height. The number should be 912, not 916.

image

Questions

  1. Why the following code is not in the if (window_manager->IsMaximized()) block

image

  1. Why do you use 9 instead of 8 here?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants