Add LightOperationExecutor support for parameterless operations #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2024 18:32
LightDataFetcher do not require materialised DataFetchingEnvironment to execute and are cheaper to run.
…r.get(DataFetchingEnvironment) to execute
|
Hi! These are interesting PRs, thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LightOperationExecutor is a performance improvement over OperationExecutor for simple queries as it implements
LightDataFetcherinterface from GraphQL-Java #2953 and yields about 5% performance improvement in simple queries.LightDataFetcher implementations do not require
DataFetchingEnvironmentfor getting values and are considered cheaper to execute as DFE is not constructed for the query.This also makes the
DataFetchingEnvironmentattribute ofResolutionEnvironmentprivate and instead returns it via a getter since now it can either be a materialised object or wrapped in aSupplier. Also, I have removed some of the attributes ofResolutionEnvironmentas it required DFE to be materialised.