Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo is not indexed #26

Open
Seasawher opened this issue Apr 8, 2024 · 8 comments
Open

repo is not indexed #26

Seasawher opened this issue Apr 8, 2024 · 8 comments
Labels
A-search Area: Package search. PRs without this will skip searching. C-bug Category: A bug. C-enhancement Category: Issue requires a new feature.

Comments

@Seasawher
Copy link

repo https://github.com/lean-ja/lean-by-example has not been indexed by Reservoir

I think this repo satisfies the inclusion criteria https://reservoir.lean-lang.org/inclusion-criteria.

@tydeu
Copy link
Member

tydeu commented Apr 18, 2024

@Seasawher I have now figured out the problem. Lean by example is a repository generated from a template. GitHub treats categorizes thus repositories as forks from the perspective of repository / code search. Reservoir does not include forks in its indexing (and cannot, as this would produce to many results), thus it does not pick up Lean by example.

It is probably worth clarifying this in the inclusion criteria.

@Seasawher
Copy link
Author

Thank you. In the future, will there be a feature that allows a repository to be indexed by Reservoir even if it is a fork?

@Seasawher Seasawher reopened this Apr 19, 2024
@tydeu
Copy link
Member

tydeu commented Apr 19, 2024

@Seasawher Yes, probably. It will likely be part of a manual package registration process that will also solve #13.

@Seasawher
Copy link
Author

Thanks!

@Seasawher
Copy link
Author

Seasawher commented Apr 21, 2024

@tydeu

why this repo is included? This is also generated from template.
https://reservoir.lean-lang.org/@Joonas-vonlerber/Game

@Seasawher Seasawher reopened this Apr 21, 2024
@tydeu
Copy link
Member

tydeu commented Apr 24, 2024

@Seasawher I am not sure. 😕 When searching repositories the way Riposte does manually, it does not appear in the search, but it apparently appeared once and got indexed then. I am not sure what caused to appear in the search at the time and not now. As a generated repository, it theoretically should not have appeared in the search according to GitHub's apparent rules. Maybe its owner created it as a normal repository first and then recreated as a generated one and that is why it got indexed? Alternatively maybe there is some race condition in GitHub were the search saw it as normal repository before it got recorded as fork? I sadly have no clue. 😞

@Seasawher
Copy link
Author

Could the following repositories be added to Reservoir?

@tydeu
Copy link
Member

tydeu commented May 6, 2024

@Seasawher Sorry for the late reply! I would be happy to do this; however, I do not currently have a process for manually adding repositories to the Reservoir index, so this will have until I have the time to do so.

@tydeu tydeu added C-bug Category: A bug. C-enhancement Category: Issue requires a new feature. labels May 7, 2024
@tydeu tydeu added the A-index Area: Package index. PRs without this will skip indexing. label Jul 22, 2024
@tydeu tydeu added A-search Area: Package search. PRs without this will skip searching. and removed A-index Area: Package index. PRs without this will skip indexing. labels Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-search Area: Package search. PRs without this will skip searching. C-bug Category: A bug. C-enhancement Category: Issue requires a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants