Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data types in doc-blocks #54

Merged
merged 2 commits into from
Jun 7, 2018
Merged

Add data types in doc-blocks #54

merged 2 commits into from
Jun 7, 2018

Conversation

sanjeevkpandit
Copy link
Contributor

@sanjeevkpandit sanjeevkpandit commented Jun 7, 2018

closes #53

@codecov-io
Copy link

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #54   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         191    191           
=====================================
  Hits          191    191
Impacted Files Coverage Δ
src/helpers/datetime.js 100% <ø> (ø) ⬆️
src/helpers/formatters.js 100% <ø> (ø) ⬆️
src/helpers/math.js 100% <ø> (ø) ⬆️
src/helpers/conditionals.js 100% <ø> (ø) ⬆️
src/helpers/html.js 100% <ø> (ø) ⬆️
src/helpers/strings.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 937494a...3bed017. Read the comment docs.

Copy link
Member

@mesaugat mesaugat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 🏅

@mesaugat mesaugat merged commit bf4ecbb into master Jun 7, 2018
@mesaugat mesaugat deleted the params-types-in-doc branch June 7, 2018 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper formatting of JSDoc
4 participants