-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add locale based date formatting #73
Add locale based date formatting #73
Conversation
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 8
Lines ? 201
Branches ? 0
==========================================
Hits ? 201
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
@rhanton Thanks for the PR. Please do the above requested changes and we'll review again. |
@kabirbaidhya & @mesaugat if you can look at this again, it would be much-appreciated. We're hoping it will be possible to get a build with this code in the next week so we can pull it into some internal libraries and make some development timelines that are coming up soon. Thanks for your help! |
@rhanton Everything else looks good. Please do the requested changes and then we'll merge and do a patch. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution 👍 🎉
👏 Much thanks @kabirbaidhya ! I'm a Java developer by trade, so your input was incredibly helpful. Thanks for taking my team member Ryan Robinson's PR on "abs" a while back too. |
@rhanton For sure; I'm glad it helped. Please feel free for any kind of contributions in the future. |
Adding additional date handler for providing a locale ISO-3166-1 string if you need formatting that is locale-specific called formatLocaleDate.
Adding a helper specifically for that. Open to ideas on naming etc. I'm also not an amazing node/js developer, so if someone can check my code/tests, that would be excellent.
Fixes #72