[don't merge until v1.2.0] Remove deprecations for v1.2.0 #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
==========================================
+ Coverage 75.92% 76.02% +0.09%
==========================================
Files 81 81
Lines 7964 7962 -2
==========================================
+ Hits 6047 6053 +6
+ Misses 1917 1909 -8
|
|
Looks like tests passed in 3.8 and 3.9, but timed out in 3.7. Is there an easy way to rerun? |
|
Hi @ikmckenz! Thank you for this PR! We'll merge it once we decide that the next version will be 1.2.0. I've rerun the test, it should be all good now. |
borzunov
approved these changes
Dec 6, 2022
borzunov
changed the title
|
Any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pretty small and simple pull request. Resolves #526.