Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin-panel collection error resolved #4401

Merged

Conversation

GarvitSinghal47
Copy link
Contributor

Fixes : #4145

Summary

Description:
In the current setup, the frontend was fetching and displaying all channels without properly handling the edit flag or checking if the channels were associated with the current user_id. This inconsistency led to sporadic issues where channels would sometimes show up in the admin list and sometimes not.

Changes Made:

Modified the frontend logic to only fetch and display channels where edit is set to true or the user_id matches the current user.
Ensured proper handling to prevent channels from being displayed inconsistently in the admin list.

Manual verification steps performed

  1. Step 1
  2. Step 2
  3. ...

Screenshots (if applicable)

Does this introduce any tech-debt items?


Reviewer guidance

How can a reviewer test these changes?

Are there any risky areas that deserve extra testing?

References

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob requested a review from ozer550 January 17, 2024 14:15
@rtibbles rtibbles added this to the Studio: Q1-24 Patch milestone Jan 20, 2024
@ozer550
Copy link
Member

ozer550 commented Feb 1, 2024

After having a quick conversation with @bjester, We have decided to go forward with the prior way of creating the queryset i.e we don't want to do it all in one go, apologies for this @GarvitSinghal47! One thing to note here is your earlier commit was filtering first and then doing the annotation to the queryset which could become problematic. The right way would be to first annotate and then to filter with edit=True.

Copy link
Member

@ozer550 ozer550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ozer550 ozer550 merged commit 54e82e7 into learningequality:unstable Feb 6, 2024
13 checks passed
@akolson akolson mentioned this pull request Aug 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admins see all channel collections in their account
3 participants