Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload bloom format files in studio #4590

Merged
merged 6 commits into from
Sep 18, 2024

Conversation

nikkuAg
Copy link
Contributor

@nikkuAg nikkuAg commented Jun 12, 2024

Summary

Description of the change(s) you made

I have added the bloompub preset in the contentcuration le-utlis shared folder to allow users to upload bloom files in the studio

Screenshots

image

References

#4583
#36

Comments

When uploading the bloom file from our PC the File object created on frontend is not able to detect the mimetype of the file and hence sending null to backend in the type property. Should we hardcode it othe front endnd for this format?


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any frontend changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles self-assigned this Jun 18, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update to the published le-utils version, and just make sure we're using the code generation script.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as automated checks pass, this should be good to go.

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about the tests change, but overall this LGTM

Comment on lines +74 to +75
expect(wrapper.vm.primaryFileMapping[1].file.id).toBe('file-3');
expect(wrapper.vm.primaryFileMapping[2].file.id).toBe('file-1');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these failing before or just not testing what they were supposed to test?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They were just brittle to the order of file presets - because the bloompub preset happened to go before epub and pdf, (because alphabetical) it moved them each down a place.

@rtibbles rtibbles merged commit 1016852 into learningequality:unstable Sep 18, 2024
13 checks passed
This was referenced Sep 19, 2024
@pcenov
Copy link
Member

pcenov commented Sep 19, 2024

I confirm that it's possible to upload bloom files. There's no preview of the files and they cannot be imported in Kolibri which I guess will be implemented at a later stage.

@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants