Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update strings following UX writing review #4682

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Update strings following UX writing review #4682

merged 1 commit into from
Aug 29, 2024

Conversation

marcellamaki
Copy link
Member

No description provided.

radinamatic
radinamatic approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes are consistent with what we agreed upon during the review 👍🏽

Are these all the changes needed? I have a nagging feeling that there was something else pending... 🤔

@marcellamaki marcellamaki marked this pull request as ready for review August 27, 2024 19:50
@marcellamaki marcellamaki force-pushed the update-strings-for-bulk-editing-release branch from 4b5251d to 0d18170 Compare August 29, 2024 17:12
@marcellamaki marcellamaki force-pushed the update-strings-for-bulk-editing-release branch from 0d18170 to e07fcef Compare August 29, 2024 17:51
@marcellamaki marcellamaki merged commit 507fa32 into learningequality:unstable Aug 29, 2024
13 checks passed
@radinamatic
Copy link
Member

There are still a few strings on unstable that do not align with edits for consistency that we agreed on during the UX writing review. I marked the cells of the pending ones with the yellow background in our working document.

@radinamatic radinamatic mentioned this pull request Aug 29, 2024
Merged
@radinamatic
Copy link
Member

Final manual QA on the unstable branch confirms the fix.

@akolson akolson mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radinamatic radinamatic radinamatic approved these changes

Assignees

@radinamatic radinamatic

Labels
None yet
Projects
None yet
Milestone
Studio: Bulk Editing Release
Development

Successfully merging this pull request may close these issues.
2 participants
@marcellamaki @radinamatic