Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edit permission check on edit title and description icon button #4710

Merged

Conversation

akolson
Copy link
Member

@akolson akolson commented Sep 4, 2024

Summary

Description of the change(s) you made

This pr prevents users with view-only permissions from editing a channel title and description.

Manual verification steps performed

Screenshots (if applicable)

Before
image

After: Option now removed if view-only
image

Does this introduce any tech-debt items?

No

Reviewer guidance

How can a reviewer test these changes?

  1. Create a user A, and sign in as user A
  2. Create a channel and add some content.
  3. Create another user B
  4. Open a channel and select the 'Share channel' option
  5. Share the channel with user B by selecting the Can view option
  6. The Edit title and description icon next to the resources and folders should not be visible

References

Fixes #4701

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akolson!! LGTM!

@akolson akolson merged commit 7c97b71 into learningequality:unstable Sep 9, 2024
13 checks passed
@pcenov
Copy link
Member

pcenov commented Sep 10, 2024

Great @akolson - I also confirm that #4701 is fixed!

@akolson akolson mentioned this pull request Sep 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
@akolson akolson deleted the bulk-edit-permission-tweaks branch October 31, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable - A user with "View-only" permissions can edit the title and description of resources and folders
3 participants