Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KCard prototype files #4712

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Sep 5, 2024

Summary

This PR uses the latest KCard for the RecommendedResourceCard and remove the Studio KCard prototype files

Screenshots (if applicable)

Screenshot 2024-09-05 at 15 27 09

Reviewer guidance

Call the RecommendedResourceCard anywhere you wish to use it.
Its worthy noting that RecommendedResourceCard might get disorted as the card width grows bigger but it will be fixed in this issue learningequality/kolibri-design-system#773

References

#4597

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@AllanOXDi AllanOXDi changed the base branch from unstable to search-recommendations September 5, 2024 12:54
@AllanOXDi AllanOXDi changed the base branch from search-recommendations to unstable September 5, 2024 12:55
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and make sense to me! @MisRob, Any other thoughts on this, otherwise will proceed to merge?
Additional changes will need to be made to this component, but this is sufficient for now.

Thanks @AllanOXDi

@akolson
Copy link
Member

akolson commented Sep 5, 2024

After chat with @MisRob, merging this!

@akolson akolson merged commit 26fecec into learningequality:unstable Sep 5, 2024
13 checks passed
@akolson akolson mentioned this pull request Sep 13, 2024
@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants