Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change depends to imports #12

Closed
lmullen opened this issue May 8, 2018 · 1 comment
Closed

Change depends to imports #12

lmullen opened this issue May 8, 2018 · 1 comment

Comments

@lmullen
Copy link

lmullen commented May 8, 2018

Issue from JOSS review

The package currently uses Depends in the DESCRIPTION for its dependencies. Best practice is to use Imports, and then to refer to the function by its namespace: e.g., somepackage::some_func(). See Hadley Wickham's R Packages.
@lebebr01
Copy link
Owner

Made this change. I was not aware of the Imports section, however have been using the package::func() syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmullen @lebebr01