-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: pdfsearch: Search Tools for PDF Files #668
Comments
Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @lmullen it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
OK, @jeroen is now a reviewer |
@whedon commands |
Here are some things you can ask me to do:
|
@lebebr01 what is the reason pdfsearch 0.2.0 is not on CRAN yet? |
@jeroen was primarily waiting to submit to CRAN until after the review. I'm open to submitting prior to review and then submitting another version after the review if there are changes made. |
@lebebr01 can you ping me here when lebebr01/pdfsearch#10 has been fixed, so I can proceed with testing and reviewing the package (on macos ;)) |
OK thank you for fixing. LGTM! |
Hi @lmullen - please complete your review when you get a chance. |
First, a belated thank you to @jeroen for your review. Secondly, thank you to @lmullen for your review. I have made the suggested edits related to the code and vignette issues identified above. I also have expanded on the significance and usage of the package in research settings in the JOSS paper and README. My thoughts are that this package would be of primary interest to those doing research syntheses or meta-analyses. I also present description of an ongoing research project using the package to explore the evolution of statistical software and quantitative methods used in published social science research that will be presented at JSM this summer. I'd be interested in your thoughts on whether this expanded discussion is compelling. Changes and a few additional comments can be seen in the issues above. I also tried to link major changes via commits in the issues above. |
Two minor comments on the revisions to the JOSS paper. "instead of searching the entire text of a document specific portions of the text": comma after document. "a preprint will be posted here." I'm not sure from the context where "here" is. Other than that I am fine with the revisions, which I have reviewed. |
Thank you @lmullen. I made the suggested edits to the README file (lebebr01/pdfsearch@90cb73d), I was not able to find these lines in the JOSS paper. |
👍 |
@karthik - I think this is good to accept? |
Good by me.
On Tue, Jun 19, 2018 at 7:14 PM Karthik Ram ***@***.***> wrote:
@lebebr01 <https://github.com/lebebr01> Just returning from vacation. I'm
happy to accept (assuming @lmullen <https://github.com/lmullen> is not
waiting on anything else for the final checks). Please archive your
software on Zenodo and post the DOI here so we can proceed with next steps.
🙏
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#668 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALNeOf2Hk_q-erW07UYRgu8KMSms88bks5t-YW6gaJpZM4TKu_r>
.
--
Lincoln Mullen
Assistant Professor, Department of History & Art History
George Mason University
|
@karthik I've archived the latest version to Zenodo and the DOI is 10.5281/zenodo.1294067 (https://doi.org/10.5281/zenodo.1294067). |
@whedon set 10.5281/zenodo.1294067 as archive |
OK. 10.5281/zenodo.1294067 is the archive. |
@whedon generate pdf |
|
@karthik are we good to accept here? |
Yes good to accept. Was waiting on PDF and forgot to ping you. |
@lmullen, @jeroen - many thanks for your reviews here and to @karthik for editing this submission ✨ @lebebr01 - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00668 ⚡ 🚀 💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @lebebr01 (Brandon LeBeau)
Repository: https://github.com/lebebr01/pdfsearch
Version: v0.2.0
Editor: @karthik
Reviewers: @lmullen, @jeroen
Archive: 10.5281/zenodo.1294067
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@lmullen, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @karthik know.
Review checklist for @lmullen
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @jeroen
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: