This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
txpool: sync.Mutex instead of RWMutex #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Nov 14, 2022
michaelneuder
pushed a commit
to michaelneuder/erigon
that referenced
this pull request
Nov 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplelru is not thread safe. During the
Getoperation, the recentness of the accessed item is updated, so it is not a pure read-operation. Therefore, the mutex we need to protect the LRUs in txpool is a full mutex, notRLock. See erigontech/erigon#4679 (comment) and ethereum/go-ethereum#26164.Also, RWMutex has a performance overhead compared with the vanilla one (see, for example, golang/go#38813).
Kudos to Martin Swende for pointing to the issue.