Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optimisation causing failures #198

Closed
wants to merge 1 commit into from

Conversation

JonasVautherin
Copy link
Contributor

Resolves #146.

This seems like an optimisation (it should be fine, though suboptimal, to sometimes run the toolchain twice) that breaks some use-cases (different people complained in #146). I therefore believe that it should be removed (and brought back properly if there is a need at some point).

Also @leetal said:

I cannot remember either why i changed that in the first place... Seems to run equally good using both the "old" solution as with the ENV solution.

Seems like it should be fine to just remove it.

Remove an optimisation that is causing failures with some setups.
@JonasVautherin
Copy link
Contributor Author

@leetal kindly pinging here 😊

@JonasVautherin
Copy link
Contributor Author

I don't think this will get more attention, so I'm closing this to clean my list of open PRs.

@JonasVautherin JonasVautherin deleted the patch-1 branch March 18, 2024 22:45
@leetal
Copy link
Owner

leetal commented Mar 19, 2024

I'm afraid this could break existing uses of the toolchain. I'd love to integrate this fix since it will most definitely fix more than it breaks.. I can probably add some tests that covers Conan or similar use-cases just to be sure but really the only option viable would probably be to introduce a flag to gradually roll this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preventing the toolchain to run as an environment variable breaks further runs.
2 participants