Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated on CMake's documentation:
This is problematic when building on a mac for a mac because
CMAKE_CROSSCOMPILING
will be enabled, causing wonky behavior when building projects that relies on this variable, such as gRPC.By firstly assigning the
CMAKE_SYSTEM_NAME
to a variable and checking it againstCMAKE_HOST_SYSTEM_NAME
, we prevent this behavior andCMAKE_CROSSCOMPILING
will only be set when it is actually necessary.