Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add npm ignore #5

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Add npm ignore #5

merged 1 commit into from
Apr 13, 2019

Conversation

jdneo
Copy link

@jdneo jdneo commented Apr 13, 2019

No description provided.

@jdneo jdneo requested review from poppinlp and Vigilans April 13, 2019 06:32
@jdneo jdneo merged commit 6ada49d into master Apr 13, 2019
@jdneo jdneo deleted the cs/ignore branch April 13, 2019 07:18
@poppinlp
Copy link

Maybe we could use files field which is an array of pattern in package.json to specify the files which we wanna include.
It's a white list mode which may reduce some unexpected ignores.

@jdneo
Copy link
Author

jdneo commented Apr 15, 2019

@poppinlp Good to know that. Would you mind to make a PR for that?

@poppinlp
Copy link

OK. I'll do it tonight.
Seems I'm always looking the past things since I'm still in the interview process. T_T

@poppinlp
Copy link

And I owe a new leetcode module design. I still remember that. But I'm not pretty sure my time recently. 😢

@poppinlp poppinlp mentioned this pull request Apr 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vigilans Vigilans Vigilans approved these changes

@poppinlp poppinlp Awaiting requested review from poppinlp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdneo @poppinlp @Vigilans