fix: can't sign in by cookie on leetcode-cn site #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdneo Hi, can you help me to review this pull request please to fix the cookie sign in issue please? I will also create another pull request later on to add an option to disable translation on the CN end point. |
|
@yihong0618 would you mind to take a look? 😄 |
yihong0618
reviewed
Mar 29, 2021
|
LGTM |
jdneo
approved these changes
Mar 31, 2021
|
Thank you @yihong0618 @dzz007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the problem where leetcode-cn sign-in by cookie fails.
It seems like leetcode-cn is now using the same sign-in cookie mechanism as the US site.