Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test module detection on Mill 0.11.7+ #74

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Improve test module detection on Mill 0.11.7+ #74

merged 5 commits into from
Feb 6, 2024

Conversation

lefou
Copy link
Owner

@lefou lefou commented Feb 4, 2024

This prepared mill-jacoco to better catch exactly the correct module sources. It especially detects any custom test module and excludes it's coverage data from the reports. Perviously, we only detected test modules by naming conventions, which was rather sloppy.

Fix #3

This feature only works when used with Mill 0.11.7 or newer. This is a soft requirement and will checked at runtime.

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dfc6c1b) 100.00% compared to head (0353273) 100.00%.

❗ Current head 0353273 differs from pull request most recent head 902b2a2. Consider uploading reports for the commit 902b2a2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           10        10           
=========================================
  Hits            10        10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lefou lefou changed the title Use upcoming type selectors in target queries Improve test module detection on Mill 0.11.7+ Feb 6, 2024
@lefou lefou marked this pull request as ready for review February 6, 2024 11:46
@lefou lefou merged commit a028742 into main Feb 6, 2024
5 checks passed
@lefou lefou deleted the typeselector branch February 6, 2024 11:54
@lefou lefou added this to the after 0.0.3 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] being able to detect all test modules
1 participant