Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage, addresses #7 #9

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Increase test coverage, addresses #7 #9

wants to merge 20 commits into from

Conversation

rseyyedi
Copy link

1st try to make a test case

@codecov
Copy link

codecov bot commented Sep 30, 2018

Codecov Report

Merging #9 into master will increase coverage by 1.75%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #9      +/-   ##
=========================================
+ Coverage   75.45%   77.2%   +1.75%     
=========================================
  Files           2       2              
  Lines         440     430      -10     
=========================================
  Hits          332     332              
+ Misses        108      98      -10
Impacted Files Coverage Δ
test/constexpr_tests.cpp 100% <100%> (ø) ⬆️
include/cpp_box/arm.hpp 69.56% <0%> (+3.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2add388...d0569f0. Read the comment docs.

#7
Add testcase for memory instruction - Immediate value
@rseyyedi rseyyedi closed this Oct 3, 2018
@rseyyedi rseyyedi changed the title issue #7 #7 Oct 3, 2018
@rseyyedi rseyyedi reopened this Oct 3, 2018
@rseyyedi
Copy link
Author

rseyyedi commented Oct 3, 2018

2nd Try

@rseyyedi
Copy link
Author

rseyyedi commented Oct 3, 2018

constexpr_tests.cpp:24:3: in 'constexpr' expansion of '#'result_decl' not supported by dump_expr#
<expression error>cpp_box::arm::System<1024, std::array<unsigned char, 1024> >::process(instruction#7)'

include/cpp_box/arm.hpp:47:45: error: right operand of shift expression '(0 >> 4294967292)' is >= than the precision of the left operand [-fpermissive]
return val & (static_cast<Value>(1) << bit);

@lefticus lefticus changed the title #7 Increase test coverage, addresses #7 Oct 9, 2018
@lefticus
Copy link
Owner

lefticus commented Oct 9, 2018

Looks like a start - just need to actually verify that it did what you wanted it to do with some test other than it just executing.

@rseyyedi
Copy link
Author

Looks like a start - just need to actually verify that it did what you wanted it to do with some test other than it just executing.

Yeah, I was reading what would happen to registers after memory manipulation and what to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants