Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all pieces of original Land Manager permissions system #216

Open
9 of 15 tasks
mradamcox opened this issue Aug 17, 2021 · 0 comments
Open
9 of 15 tasks

Remove all pieces of original Land Manager permissions system #216

mradamcox opened this issue Aug 17, 2021 · 0 comments
Assignees
Labels
backend requires server-side (python) work
Milestone

Comments

@mradamcox
Copy link
Contributor

mradamcox commented Aug 17, 2021

Once the new LandManager profile system has been fully implemented, a lot of content can be removed from the codebase.

code removal

  • get_rules(), get_state_node_match(), and quick_query()methods in SiteFilter (and perhaps more)
  • user_can_access_resource_instance decorator
  • UserXResourceInstanceAccess hms model
  • user_is_old_landmanager() in permission_backend
  • hms/utils.py (entire file will be unnecessary)
    Region fpan model Originally thought this could be removed, but keeping it for the ScoutProfile.region_choices relationship is better for now.
    ManagedArea fpan model thought this could be removed, but it's needed by many migrations. Will need a serious refactor to fully remove.
  • fpan/admin.py registration
    fpan/models.py can't remove this until its models are fully deprecated
  • permissions defintions in settings.py
  • any old permissions-related code in fpan-data
  • scout_assignemt function which attempts to update the UserXResourceInstanceAccess table

data removal

  • All tiles from the "Located in..." branch of each resource model
  • The "Located in..." branch itself from each resource model
  • Managed Area concepts/collections in the RDM
  • Managed Area Categories concepts/collections in the RDM
  • Managing Agency concepts/collections in the RDM
  • save all above changes back to the fpan-data package
@mradamcox mradamcox added the backend requires server-side (python) work label Aug 17, 2021
@mradamcox mradamcox self-assigned this Aug 17, 2021
@mradamcox mradamcox added this to the Wishlist milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend requires server-side (python) work
Projects
None yet
Development

No branches or pull requests

1 participant