Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow relative paths in scoped packages #12

Merged
merged 19 commits into from
Feb 1, 2017

Commits on Nov 20, 2016

  1. Configuration menu
    Copy the full SHA
    ec16eb2 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2016

  1. Introduce resolver

    The resolver module implements a path resolving algorithm that
    leverages node's own require.
    
    This has a couple benefits:
    * more likely to continue working as expected when features are
    introduced to npm/node
    * reduction of code duplication (npm/node already implements the module
    resolution we are interested in for this project)
    * allow the use of NODE_PATH variable to control module directory
    
    Additionally, `resolver` leverages `Package` and `Import` constructors
    which implement some of the same logic previously found on the `find`
    function in `lib/importer.js`. The benefit of creating these
    constructors will obvious when unit tests are introduced for this
    project.
    
    `Package`: implements logic related to retrieving package data, such as
    getting the package.json, and getting the sass 'main' file for a given
    package.
    
    `Import`: implements logic to make sense of a sass import.
    GeorgeTaveras1231 committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    230e069 View commit details
    Browse the repository at this point in the history
  2. Fix test run

    This allows the tests to work consistently
    GeorgeTaveras1231 committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    9dab304 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1c4ce24 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a8cad50 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4b4fdcf View commit details
    Browse the repository at this point in the history
  6. Attempt to be cross platform friendly

    Also improved style in tests
    GeorgeTaveras1231 committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    17e3c65 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3dace1a View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2016

  1. Configuration menu
    Copy the full SHA
    d61b2c4 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2016

  1. Configuration menu
    Copy the full SHA
    ca314c7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df955e5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    66f9799 View commit details
    Browse the repository at this point in the history
  4. Remove string expansion fron test script

    Because string expansion is not compatible with all shells
    GeorgeTaveras1231 committed Nov 25, 2016
    Configuration menu
    Copy the full SHA
    3b89108 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f7bad67 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f0a7a90 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    550fff0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f74e5bf View commit details
    Browse the repository at this point in the history
  9. Introduce Promises for async operations

    This helps some of the async code easier to read
    GeorgeTaveras1231 committed Nov 25, 2016
    Configuration menu
    Copy the full SHA
    0375885 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3084a15 View commit details
    Browse the repository at this point in the history