Allow to install packed extensions from URL or local file #1456

ixrock · 2020-11-19T22:54:56Z

Done:

UI part of extensions-page (unpack, validate, load .tgz)
new react-component Clipboard for copying html-element full text-content or partial into clipboard
new react-component DropFileInput to handle drag-n-dropped files from external app, e.g. Finder / other file explorer (logic adopted originally from add-cluster-page)

Todo:

fix: downloading file by URL
unpack requested extensions to ~/.k8slens/extensions

requires #1461 #1482 (otherwise just restart the app after installation)
close #1227

Screenshots:

Signed-off-by: Roman <[email protected]>

… in add-cluster-page) Signed-off-by: Roman <[email protected]>

Signed-off-by: Roman <[email protected]>

…ard` Signed-off-by: Roman <[email protected]>

src/renderer/components/+add-cluster/add-cluster.tsx

Signed-off-by: Roman <[email protected]>

# Conflicts: # src/common/utils/index.ts

Signed-off-by: Roman <[email protected]>

package.json

src/renderer/components/notifications/notifications.store.ts

ixrock · 2020-11-23T22:05:10Z

@jakolehm PTAL / test

Signed-off-by: Roman <[email protected]>

src/extensions/extension-manager.ts

src/renderer/components/+extensions/extensions.tsx

package.json

src/renderer/components/+extensions/extensions.tsx

Signed-off-by: Roman <[email protected]>

# Conflicts: # src/renderer/components/+extensions/extensions.tsx # src/renderer/utils/downloadFile.ts

Signed-off-by: Roman <[email protected]>

src/common/utils/downloadFile.ts

src/common/utils/index.ts

src/common/utils/tar.ts

src/renderer/components/+extensions/extensions.tsx

Nokel81 · 2020-11-24T16:58:02Z

src/renderer/components/+extensions/extensions.tsx

+  }
+
+  getExtensionDestFolder(name: string) {
+    return path.join(this.extensionsPath, sanitizeExtensionName(name));


This sanitation is not as complete as you think. So far I don't think we put any requirements on extension names and (at least on Windows) we do not sanitize out \ or even .s.

Plus I don't see why @ cannot be part of the dest folder path.

Anyway we have to sanitize it since name might contain / and currently loading extensions supported only from single level from ~./k8slens/extensions/<folder>

True, but I am thinking more about security. If someone crafted the name to be @foo\..\..\/blarr on windows, this would be "sanitized" to foo\..\..\-blarr and if we were ever to say "overWrite: true" (which I think I saw in this PR somewhere) then we would be writing to some unknown place.

It's not valid name for NPM-package (@foo\..\..\/blarr) so no need to worry about it.
@jakolehm your word?

@Nokel81 has a point here.. I think it's possible for an attacker to handcraft a package with invalid name. Of course if user installs a malicious package then it can do even worse things via runtime ... so maybe not super critical to fix here.

Let's create a separate issue about this.

src/renderer/components/+extensions/extensions.tsx

src/renderer/components/clipboard/clipboard.tsx

src/renderer/components/input/drop-file-input.tsx

src/renderer/components/notifications/notifications.store.ts

Nokel81 · 2020-11-24T19:06:09Z

src/renderer/components/+extensions/extensions.tsx

+            theme="round-black"
+            iconLeft="link"
+            placeholder={`URL to packed extension (${this.supportedFormats.join(", ")})`}
+            validators={InputValidators.isUrl}


This validator is wrong, the string "123.com" is reported as invalid. Also it seems that even if the validator returns an error we can still click the "Add extensions" button

Dunno, this is out of scope of this PR. This validator also matching to empty string which is also invalid.

The validator being wrong is yes, but not being able to click "add extensions" if it returns an error

So yeah, 123.com is invalid URL, try new URL("123.com") :D
Just prepend with http(s) and all good, lol.

BTW you might want to fix this meanwhile in separated PR! :)

src/renderer/components/+extensions/extensions.tsx

Nokel81 · 2020-11-24T19:11:25Z

Also, I tested this with https://registry.npmjs.org/@mirantis/lens-extension-cc/-/lens-extension-cc-1.0.2.tgz which is the value I got from running npm view @mirantis/lens-extension-cc dist.tarball. And this PR reported a failure because "invalid package, package.json not found".

However, if I download that package and unpack it. I get the following folder structure:

I think that this PR should handle correctly how npm bundles its code into tarballs.

Signed-off-by: Roman <[email protected]>

ixrock · 2020-11-24T20:01:28Z

I think that this PR should handle correctly how npm bundles its code into tarballs.

Yes it should and I expected it to work, so you just found one more 🐞 Congrats! 🎉 (FIXED)

Signed-off-by: Roman <[email protected]>

ixrock · 2020-11-25T06:23:48Z

@jakolehm ready to merge? any issues so far? ofc after #1510

jakolehm

LGTM. I spotted few usability issues but they should be fixed in separate PRs (I'll open issues about those).

Change requests are done

ixrock added 7 commits November 19, 2020 19:49

Option to install an extension from filesystem/url #1227 -- part 1 (UI)

6624287

Signed-off-by: Roman <[email protected]>

DropFileInput: common component to handle droped files (replaced also…

7d28a43

… in add-cluster-page) Signed-off-by: Roman <[email protected]>

fix: install via url-string on input.submit

724ee86

Signed-off-by: Roman <[email protected]>

ui tweaks & minor fixes

cc28424

Signed-off-by: Roman <[email protected]>

Merge remote-tracking branch 'origin/master' into extension_install_1277

3df6c07

more ui/ux tweaks & fixes

97bcb49

Signed-off-by: Roman <[email protected]>

layout fixes

51f686c

Signed-off-by: Roman <[email protected]>

ixrock added enhancement New feature or request area/extension Something to related to the extension api labels Nov 19, 2020

ixrock added this to the 4.0.0 milestone Nov 19, 2020

ixrock requested a review from a team November 19, 2020 22:54

ixrock marked this pull request as draft November 19, 2020 22:55

ixrock changed the title ~~[Draft]: Install additional extensions from local-files or by URL~~ [Draft]: Install custom extensions from local-files or by URL (.tgz) Nov 19, 2020

component renaming: copy-to-click => copy-to-clipboard => `clipbo…

f505dab

…ard` Signed-off-by: Roman <[email protected]>

panuhorsmalahti reviewed Nov 20, 2020

View reviewed changes

src/renderer/components/+add-cluster/add-cluster.tsx Show resolved Hide resolved

jakolehm mentioned this pull request Nov 20, 2020

Lens should notice added/removed extension folders #1461

Closed

reworks -- part 1

78dcd5d

Signed-off-by: Roman <[email protected]>

ixrock changed the title ~~[Draft]: Install custom extensions from local-files or by URL (.tgz)~~ Install extensions from NPM or from URL to tarball.tgz Nov 20, 2020

ixrock changed the title ~~Install extensions from NPM or from URL to tarball.tgz~~ Allow to install extensions from .tgz (npm / url) Nov 22, 2020

ixrock added 5 commits November 23, 2020 12:30

fix downloading file, added common/utils/downloadFile

9284611

Signed-off-by: Roman <[email protected]>

confirm before install, unpack tar first steps

5093262

Signed-off-by: Roman <[email protected]>

installation flow, extracting .tgz

88950b0

Signed-off-by: Roman <[email protected]>

Merge remote-tracking branch 'origin/master' into extension_install_1277

de93812

# Conflicts: # src/common/utils/index.ts

clean up, fix lint issues

150c3dc

Signed-off-by: Roman <[email protected]>

ixrock marked this pull request as ready for review November 23, 2020 21:57

ixrock commented Nov 23, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

src/renderer/components/notifications/notifications.store.ts Show resolved Hide resolved

update .azure-pipelines.yml

8b6616a

Signed-off-by: Roman <[email protected]>

ixrock requested a review from a team November 23, 2020 22:13

ixrock commented Nov 23, 2020

View reviewed changes

src/extensions/extension-manager.ts Outdated Show resolved Hide resolved

panuhorsmalahti reviewed Nov 24, 2020

View reviewed changes

src/renderer/components/+extensions/extensions.tsx Show resolved Hide resolved

panuhorsmalahti reviewed Nov 24, 2020

View reviewed changes

src/renderer/components/+extensions/extensions.tsx Outdated Show resolved Hide resolved

panuhorsmalahti reviewed Nov 24, 2020

View reviewed changes

src/renderer/components/+extensions/extensions.tsx Outdated Show resolved Hide resolved

panuhorsmalahti reviewed Nov 24, 2020

View reviewed changes

src/renderer/components/+extensions/extensions.tsx Outdated Show resolved Hide resolved

panuhorsmalahti reviewed Nov 24, 2020

View reviewed changes

src/renderer/components/+extensions/extensions.tsx Outdated Show resolved Hide resolved

jakolehm requested changes Nov 24, 2020

View reviewed changes

package.json Outdated Show resolved Hide resolved

src/renderer/components/+extensions/extensions.tsx Outdated Show resolved Hide resolved

jakolehm reviewed Nov 24, 2020

View reviewed changes

src/renderer/components/+extensions/extensions.tsx Outdated Show resolved Hide resolved

jakolehm reviewed Nov 24, 2020

View reviewed changes

src/renderer/components/+extensions/extensions.tsx Outdated Show resolved Hide resolved

ixrock changed the title ~~Allow to install extensions from .tgz (npm / url)~~ Allow to install packed extensions URL or local file Nov 24, 2020

ixrock changed the title ~~Allow to install packed extensions URL or local file~~ Allow to install packed extensions from URL or local file Nov 24, 2020

ixrock added 5 commits November 24, 2020 15:37

fixes & refactoring

5fc0c63

Signed-off-by: Roman <[email protected]>

Merge remote-tracking branch 'origin/master' into extension_install_1277

e460b3f

# Conflicts: # src/renderer/components/+extensions/extensions.tsx # src/renderer/utils/downloadFile.ts

fix lint harder :/

12c3422

Signed-off-by: Roman <[email protected]>

fix validation

d050d6c

Signed-off-by: Roman <[email protected]>

fix validation harder

1c17420

Signed-off-by: Roman <[email protected]>

Nokel81 reviewed Nov 24, 2020

View reviewed changes

Nokel81 previously requested changes Nov 24, 2020

View reviewed changes

responding to comments, fixed package validation

55c284f

Signed-off-by: Roman <[email protected]>

ixrock added 2 commits November 25, 2020 01:02

common/utils/tar.ts: reject with Error-type

639bc1a

Signed-off-by: Roman <[email protected]>

fix: unit-tests

4c3a8e2

Signed-off-by: Roman <[email protected]>

jakolehm mentioned this pull request Nov 25, 2020

Tweak install extension ux #1510

Merged

jakolehm approved these changes Nov 25, 2020

View reviewed changes

panuhorsmalahti approved these changes Nov 25, 2020

View reviewed changes

jakolehm merged commit 77ae315 into master Nov 25, 2020

jakolehm deleted the extension_install_1277 branch November 25, 2020 07:55

jakolehm mentioned this pull request Nov 25, 2020

Release v4.0.0-rc.1 #1525

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow to install packed extensions from URL or local file #1456

Allow to install packed extensions from URL or local file #1456

ixrock commented Nov 19, 2020 •

edited

Loading

ixrock commented Nov 23, 2020

Nokel81 Nov 24, 2020

ixrock Nov 24, 2020

Nokel81 Nov 24, 2020

ixrock Nov 24, 2020

jakolehm Nov 25, 2020

Nokel81 Nov 24, 2020

ixrock Nov 24, 2020

Nokel81 Nov 24, 2020

ixrock Nov 24, 2020

ixrock Nov 24, 2020

Nokel81 commented Nov 24, 2020

ixrock commented Nov 24, 2020 •

edited

Loading

ixrock commented Nov 25, 2020

jakolehm left a comment

Allow to install packed extensions from URL or local file #1456

Allow to install packed extensions from URL or local file #1456

Conversation

ixrock commented Nov 19, 2020 • edited Loading

ixrock commented Nov 23, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nokel81 commented Nov 24, 2020

ixrock commented Nov 24, 2020 • edited Loading

ixrock commented Nov 25, 2020

jakolehm left a comment

Choose a reason for hiding this comment

ixrock commented Nov 19, 2020 •

edited

Loading

ixrock commented Nov 24, 2020 •

edited

Loading