-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to support arm64 (and Apple M1) #185
Conversation
Amazing, can't wait for this to land in mainline! |
I've successfully tested it and working well on M1 Pro 16" 👍 |
**NOTE**: Not sure where this would go in an accepted PR. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for approving the PR. There is the outstanding question of where these notes should go. If down here in the README.md
is fine, then I should remove these lines.
There is also the question of whether the maintainers of this repo will run the buildx
command and publish a new image? I'm not sure what the release process is here. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dougdonohoe I would definitely recommend using something like GitHub Actions to perform the building and publishing of the multi-platform container. Please see the example here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no rights for on this repository, so am unable to add new Github Actions. I can't actually merge this PR.
@andmarios, do you have any updates on this PR? We used it more widely as most engineers are upgrading to M1 macs. |
Would love to see this merged asap! |
I switched to using Confluent Platform with Docker Compose and it works great with Apple Silicon. Also, they have a build that doesn't require ZooKeeper which can be found here. |
Merged finally after quite some time! I am sorry for the huge delay; it was due to both capacity and blockers from our product. There was a huge workstream behind the scenes to prepare the product and CICD for arm64 support, and the developer-focused images (fast-data-dev and box) were close to last on the long chain of required changes. Actually, Box is next and I hope it will come out in the next few days. Anyhow, thank you for your work; it was great! 💯 The arm64 images for fast-data-dev are already on docker hub. 😄 |
Building off of great work by @faberchri, I modified the
caddy
andgotty
installs to work for botharm64
andamd64
.The end of the
README.md
includes instructions on how to build the image usingdocker buildx
. Not sure where this should actually go, but happy to move it elsewhere.I also published the image to https://hub.docker.com/r/dougdonohoe/fast-data-dev.