Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space in the format for a future MAC #54

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

mdekstrand
Copy link
Member

@mdekstrand mdekstrand commented Feb 18, 2024

This adds a new field to the file trailer to eventually store a MAC, to enable #55 without requiring incompatible format changes.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c762626) 94.68% compared to head (7ed364f) 94.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   94.68%   94.72%   +0.03%     
==========================================
  Files           8        8              
  Lines         546      550       +4     
==========================================
+ Hits          517      521       +4     
  Misses         29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 051a44a into lenskit:main Feb 18, 2024
14 checks passed
@mdekstrand mdekstrand deleted the feature/space-for-mac branch February 18, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant